airbyte/mcp/http_main.py (1)

101-107: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Extract the MCP_SERVER_URL lookup into a shared helper?

The os.getenv(MCP_SERVER_URL_ENV, ...) block at lines 103-106 duplicates the same logic in main() at lines 117-120. If the default URL format ever changes, both spots need updating. Would it make sense to extract a small helper like _get_server_url() and use it in both places? wdyt?

♻️ Proposed refactor

+def _get_server_url() -> str:
+    return os.getenv(
+        MCP_SERVER_URL_ENV,
+        f"http://localhost:{DEFAULT_HTTP_PORT}",
+    )
+
 async def mcp_landing_page(request: Request) -> HTMLResponse:  # noqa: ARG001, RUF029
     """Serve a human-friendly landing page for browser `GET`s to the MCP endpoint."""
-    server_url = os.getenv(
-        MCP_SERVER_URL_ENV,
-        f"http://localhost:{DEFAULT_HTTP_PORT}",
-    )
+    server_url = _get_server_url()
     return HTMLResponse(_render_mcp_landing_html(server_url, MCP_LANDING_DOCS_URL))

And in main():

 def main() -> None:
     """Start the Airbyte MCP server with HTTP transport."""
     logging.basicConfig(level=logging.INFO)

-    server_url = os.getenv(
-        MCP_SERVER_URL_ENV,
-        f"http://localhost:{DEFAULT_HTTP_PORT}",
-    )
+    server_url = _get_server_url()
     mcp_path = "/" if urlparse(server_url).path.strip("/") else "/mcp"

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@airbyte/mcp/http_main.py` around lines 101 - 107, Extract the duplicated
MCP_SERVER_URL_ENV lookup and default URL construction into a shared helper such
as _get_server_url(), then replace the inline logic in both mcp_landing_page and
main with that helper. Preserve the existing environment-variable and
default-value behavior.